Skip to content

track and fork upstream chrome.js #4704

Open

Description

@cscheid

See #4696. Chrome.js is an external dependency. We ported it to deno, but we now made fixes to. We should track the upstream somewhere so we can add fixes and potentially take their changes as well.

Activity

  1. added this to the v1.4 milestone on Mar 8, 2023
  2. self-assigned this
    on Mar 8, 2023
  3. cderv commented on Mar 8, 2023

    @cderv
    Member

    To share experience, for #4676 we needed to patch PdfExport plugin for Reveal and we now do that using Git patch approach after updating from upstream

    if (patches) await applyGitPatches(patches)

    In case we want to do the same thing

  4. cscheid commented on Mar 8, 2023

    @cscheid
    Author
  5. cderv commented on Mar 8, 2023

    @cderv
  6. cderv commented on Mar 8, 2023

    @cderv
    Member

    Regarding upstream project, this one probably : cyrus-and/chrome-remote-interface ?

  7. cscheid commented on Mar 8, 2023

    @cscheid
    MemberAuthor

    That's the one, yes.

  8. modified the milestones: v1.4, v1.5 on Dec 4, 2023
  9. modified the milestones: v1.5, Future on Feb 12, 2024
  10. added
    third-partyIssues involving interaction with a third-party library
    on Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or requestthird-partyIssues involving interaction with a third-party library

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions