-
Notifications
You must be signed in to change notification settings - Fork 410
Open
Labels
Milestone
Description
src/core/deno/expand-glob.ts wraps expandGlobSync from @std/fs to add globstar: true by default. It was created to work around denoland/std#3099, which has since been fixed.
Current state
Two import paths coexist for expandGlobSync:
-
src/core/deno/expand-glob.ts— wrapper addingglobstar: true, used by:src/extension/extension.tssrc/command/call/build-ts-extension/cmd.tssrc/command/call/typst-gather/cmd.ts
-
src/deno_ral/fs.ts— re-exports raw@std/fsversion (noglobstar), used by:src/command/render/template.ts
This means template.ts doesn't get the globstar: true default that other call sites get, which may or may not matter depending on usage.
Suggested cleanup
Since denoland/std#3099 is fixed:
- Remove
src/core/deno/expand-glob.tswrapper - Have all call sites import from
deno_ral/fs.ts - If
globstar: trueis still needed, pass it explicitly at call sites or add it to thedeno_ralre-export
Discovered while investigating #13927.
Reactions are currently unavailable