Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code formatting #20

Merged
merged 1 commit into from
Jun 17, 2022
Merged

code formatting #20

merged 1 commit into from
Jun 17, 2022

Conversation

nkrackow
Copy link
Contributor

I simply ran black on all the files. Not tested if it still runs/synthesizes as before but probably should?

@nkrackow nkrackow requested a review from jordens June 17, 2022 10:47
@jordens
Copy link
Member

jordens commented Jun 17, 2022

I'm ok with the result. It hurts the readability of the If() but that is outweighed IMO by the consistency gain and simply quenching all uncertainty about formatting. Maybe a quick fix would be to introduce If(condition).Then(block).Elif(condition).Then(block).Else(block) in migen.

If it synthesizes, that should be enough.

@nkrackow
Copy link
Contributor Author

I checked and it synthesizes fine. I'll merge the PR then ok?

@jordens
Copy link
Member

jordens commented Jun 17, 2022

Ah. Could you compare the verilog of with and without this patch? It should be exactly equal. If yes, this is good to merge.

@nkrackow
Copy link
Contributor Author

Checked with git diff and its exactly equal.

@nkrackow nkrackow merged commit b84537c into master Jun 17, 2022
@nkrackow nkrackow deleted the nk/code_formatting branch June 17, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants