Adding static IP configuration support #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Robert Jördens <rj@quartiq.de>
jordens
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Booster to support static IP configuration. If the user has an unspecified IP saved, DHCP is used instead.
This PR fixes #239
It also adds gateway settings back to Booster, which may be generally useful for users who have a broker outside of the local network.
For testing, I set the IP to a static address and confirmed that Booster connected to my broker from the static IP address. I then set it to 0.0.0.0 and confirmed that Booster then reconnected from a dynamic DHCP-assigned address.