Implement external MAC for ENC424J600 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
requested changes
Aug 17, 2022
Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
|
Re-enabled CI for ENC424J600. |
ryan-summers
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #214
Changes
Added an implementation of the
ExternalMactrait for ENC424J600 device. Since we are not directly implement5ing the smoltcpDevicetrait, We don't need thesmoltcp-phyfeature from theenc424j600crate anymore.I also changed the MAC address type to the one under
smoltcp. It is not strictly necessary, but we are already usingsmoltcpfor all network devices. It probably saves a few cfg blocks.