Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validating incoming settings requests #188

Merged
merged 10 commits into from
Feb 4, 2022
Merged

Validating incoming settings requests #188

merged 10 commits into from
Feb 4, 2022

Conversation

ryan-summers
Copy link
Member

@ryan-summers ryan-summers commented Feb 3, 2022 •
edited
Loading

This PR fixes #125 by adding in an update handler for incoming runtime configurations.

TODO:

@ryan-summers ryan-summers requested a review from jordens February 3, 2022 14:26
jordens
jordens requested changes Feb 3, 2022
View reviewed changes
ad5627/src/lib.rs Outdated Show resolved Hide resolved
@ryan-summers ryan-summers requested a review from jordens February 4, 2022 10:07
jordens
jordens approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inconvenient code duplication now but let's see how this pans out.

@jordens jordens merged commit 422b35e into develop Feb 4, 2022
@jordens jordens deleted the feature/handled-updates branch February 4, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordens jordens jordens approved these changes

Assignees

@jordens jordens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

limit output interlock to a sensible max value
2 participants
@ryan-summers @jordens