Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring fan hysteresis #184

Merged
merged 8 commits into from
Feb 3, 2022
Merged

Conversation

ryan-summers
Copy link
Member

@ryan-summers ryan-summers commented Feb 2, 2022

This PR fixes #62 by refactoring fans to use a static (miniconf-configured) duty cycle whenever any RF channel is enabled.

TODO:

  • Test on hardware

@jordens
Copy link
Member

jordens commented Feb 2, 2022

I suspect we can even do static "all channels off -> fans off", "any channel on -> fans at 20 %". We'd just have to measure steady state temp differential versus ambient under maximum load conditions. But I think it gets a bit more complicated with the HL version.
@gkasprow

@ryan-summers
Copy link
Member Author

It's also worth noting that if we do decide to fix the fan speed to 20% if any channel is enabled, we still have the OverTemperature fault condition to protect against the channels getting too hot.

@ryan-summers
Copy link
Member Author

@jordens Do we want to proceed with fixing to 20% now or keep the current 20->100% scaling implementation until further investigation can be done?

@jordens
Copy link
Member

jordens commented Feb 3, 2022

What about the following:

  • Add a single miniconf configurable fan setting f32 (0..1), default 0.2
  • If all channels are Off, fans are off
  • If any channel is Powered, fans are set to that configurable value.
  • Remove all other feedback/control.

src/hardware/chassis_fans.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@ryan-summers ryan-summers requested a review from jordens February 3, 2022 12:15
Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the persistent nagging, but the top level fan_speed resource irritates me.

src/main.rs Outdated Show resolved Hide resolved
@ryan-summers
Copy link
Member Author

No worries, it irked me while writing it, but my brain moved on too quickly to fix it, thanks for pointing it out!

@ryan-summers ryan-summers merged commit fe4d662 into develop Feb 3, 2022
@ryan-summers ryan-summers deleted the rs/issue-62/fan-hysteresis branch February 3, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fan hysteresis
2 participants