-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring fan hysteresis #184
Conversation
I suspect we can even do static "all channels off -> fans off", "any channel on -> fans at 20 %". We'd just have to measure steady state temp differential versus ambient under maximum load conditions. But I think it gets a bit more complicated with the HL version. |
It's also worth noting that if we do decide to fix the fan speed to 20% if any channel is enabled, we still have the |
@jordens Do we want to proceed with fixing to 20% now or keep the current 20->100% scaling implementation until further investigation can be done? |
What about the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the persistent nagging, but the top level fan_speed
resource irritates me.
No worries, it irked me while writing it, but my brain moved on too quickly to fix it, thanks for pointing it out! |
This PR fixes #62 by refactoring fans to use a static (miniconf-configured) duty cycle whenever any RF channel is enabled.
TODO: