Skip to content

Add Commhaus Foundation logo to footer #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

insectengine
Copy link
Collaborator

** If you are updating a guide, please submit your pull request to the main repository: https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc **

Copy link

github-actions bot commented Jun 3, 2025

🎊 PR Preview 9c80802 has been successfully built and deployed to https://quarkus-site-pr-2326-preview.surge.sh

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@gsmet
Copy link
Member

gsmet commented Jun 3, 2025

I'm not sure having the image part transparent is a good choice?

@insectengine
Copy link
Collaborator Author

@gsmet - added a tinted background behind the CF logo to separate from the quarkus footer background image.

@holly-cummins
Copy link
Contributor

I didn't see it part-transparent, but I think the black blackground looks a bit inconsistent with what we've done elsewhere on the footer in terms of the text. 'CommonHaus Foundation' and 'Quarkus is a CommonHaus project' is the only text that's on a black background. Even the 'Quarkus' logotype has a transparent background.

Also, with the background, the black block and surrounding text doesn't seem to be aligned quite right. On the left side the black border is aligned with the rest of the text, so the commonhaus text is indented. But on the right side the black border is roughly aligned with the right edge of the text. The right margins are ragged so 'edge' is a loose concept; I suspect in terms of layout everything actually is aligned, but the visual effect is misaligned.

image

@insectengine
Copy link
Collaborator Author

I've adjusted the opacity to be more visible on the mac laptop screen.
Screenshot 2025-06-04 at 10 59 38 AM

The Commonhaus Foundation has it's own logo spacing requirements. In order to make it easier for projects, we've made custom CF logos with project tags (so they don't need to worry about adding enough spacing for the logo on their sites).

https://github.com/commonhaus/artwork/tree/main/foundation/brand/project/svg

The text alignments for the "foo is a Commonhaus Foundation project" is part of this file and is consistent across the projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants