Add a configuration to serve a local directory with a static handler Fix #39968 #51186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
mathias82
changed the title
mathias82
changed the title
mathias82
force-pushed
the
feature-static-local-dir
branch
4 times, most recently
from
dd79a29 to
2bc57dc
Compare
ia3andy
requested changes
Nov 24, 2025
Contributor
ia3andy
left a comment
ia3andy
left a comment
There was a problem hiding this comment.
LGTM, just cleaning non changed files
| HttpServerCommonHandlers.applyFilters(filtersInConfig, httpRouteRouter); | ||
| // Headers sent on any request, regardless of the response | ||
| HttpServerCommonHandlers.applyHeaders(httpConfig.header(), httpRouteRouter); | ||
|
|
Contributor
There was a problem hiding this comment.
You can remove those changes I think
| */ | ||
| @ConfigDocSection | ||
| WebsocketServerConfig websocketServer(); | ||
|
|
ia3andy
reviewed
Nov 24, 2025
...rtx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/LocalStaticResourcesConfig.java
Show resolved
Hide resolved
Contributor
|
I also forgot, you need to add those files as watched for livereload |
mathias82
force-pushed
the
feature-static-local-dir
branch
from
9744cb6 to
691e79a
Compare
Author
ii have added @ia3andy |
mathias82
force-pushed
the
feature-static-local-dir
branch
from
691e79a to
4a1de61
Compare
ia3andy
reviewed
Nov 24, 2025
| return; | ||
| } | ||
|
|
||
| String normalizedDir = Path.of(dir).normalize().toString(); |
Contributor
There was a problem hiding this comment.
you might need toAbsolutePath here, because AFAIK the watcher is using absolute path for non resources. Debug to be sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces support for serving static files from a local directory,
configurable via
quarkus.http.local-static-resources.*.New configuration
quarkus.http.local-static-resources.enabled=true
quarkus.http.local-static-resources.path=/local-static/
quarkus.http.local-static-resources.directory=local-static
Tests
Added
LocalStaticResourcesTestwhich verifies: