-
Notifications
You must be signed in to change notification settings - Fork 3k
Expose Undertow listener configuration options #51182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cf8cc5a to
0678b3b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 PR Preview f442026 has been successfully built and deployed to https://quarkus-pr-main-51182-preview.surge.sh/version/main/guides/
|
cb3e0d5 to
f8a5e60
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| Set<String> disallowedMethods = servletRuntimeConfig.getValue().disallowedMethods() | ||
| .map(list -> { | ||
| Set<String> result = new java.util.HashSet<>(); | ||
| for (String m : list) { | ||
| result.add(m.trim().toUpperCase(Locale.ROOT)); | ||
| } | ||
| return result; | ||
| }) | ||
| .orElse(Collections.emptySet()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please avoid these lambdas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I’ve replaced the Optional.map with an explicit loop inside the recorder, so the code is now more straightforward @geoand
|
Thanks for the PR. IIUC, the description of the PR is not correct as there are no |
This comment has been minimized.
This comment has been minimized.
ec81927 to
157b6cb
Compare
This comment has been minimized.
This comment has been minimized.
157b6cb to
16cc93c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
91b4f6d to
3c55137
Compare
This comment has been minimized.
This comment has been minimized.
a36afc9 to
898a0cc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| |=== | ||
| |Configuration property |Type |Default |Description | ||
|
|
||
| |`quarkus.undertow.listener.disallowed-methods` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct, as the property is quarkus.undertow.disallowed-methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
|
||
| Example: | ||
| ---- | ||
| quarkus.undertow.listener.disallowed-methods=TRACE,TRACK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| quarkus.undertow.listener.disallowed-methods=TRACE,TRACK | ||
| ---- | ||
|
|
||
| |`quarkus.undertow.listener.record-request-start-time` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| |If enabled, Undertow records the request start timestamp. | ||
| Useful for timing, logging and request tracing. | ||
|
|
||
| |`quarkus.undertow.listener.max-parameters` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
898a0cc to
8009a6a
Compare
This comment has been minimized.
This comment has been minimized.
127fb39 to
a840319
Compare
a840319 to
28a2486
Compare
0348d4e to
e8209c9
Compare
e8209c9 to
867a4ce
Compare
This comment has been minimized.
This comment has been minimized.
c7d44d5 to
867a4ce
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ecord-request-start-time)
39db9e6 to
2fdbc27
Compare
Status for workflow
|

This PR exposes several Undertow listener configuration options that were previously available in Undertow
but not exposed through Quarkus configuration.
Added configuration properties
quarkus.undertow.listener.disallowed-methods
405 Method Not Allowedquarkus.undertow.listener.record-request-start-time
quarkus.undertow.listener.max-parameters
Motivation
These settings improve security hardening, observability, and request handling consistency.
By exposing them as Quarkus configuration options, applications can now configure Undertow behavior
directly through
application.propertieslike other existing Undertow-related settings.Documentation
Documentation has been added to: docs/src/main/asciidoc/http-reference.adoc
Notes