-
Notifications
You must be signed in to change notification settings - Fork 3k
Upgrade the default maximum datasource size to 50 #51169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🎊 PR Preview f442026 has been successfully built and deployed to https://quarkus-pr-main-51169-preview.surge.sh/version/main/guides/
|
yrodiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, but please make sure to put something in the migration guide when merging?
|
+1. I actually use 50 on the OTel Perf tests and I have profiles, if you need to look into them. |
|
I added the entry: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.31 . |
gsmet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call to revisit these values.
thanks! beat me to it :) |
This comment has been minimized.
This comment has been minimized.
|
looks like we have a bunch of integration tests verifying the default setting - I'll adjust them, please don't merge yet. |
|
Adjusted the failing tests, and rebased |
Status for workflow
|
|
TBH, I don't see a lot of value in having these tests duplicated for each database type. I suppose we can drop them next time we change the default value :). |

A proposal to improve default config a little towards more modern standards.
To be discussed: