Skip to content

Conversation

@Sanne
Copy link
Member

@Sanne Sanne commented Nov 21, 2025

A proposal to improve default config a little towards more modern standards.
To be discussed:

@Sanne Sanne added area/user-experience Will make us lose users area/agroal labels Nov 21, 2025
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

🎊 PR Preview f442026 has been successfully built and deployed to https://quarkus-pr-main-51169-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@geoand geoand requested a review from yrodiere November 24, 2025 07:44
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, but please make sure to put something in the migration guide when merging?

@brunobat
Copy link
Contributor

+1. I actually use 50 on the OTel Perf tests and I have profiles, if you need to look into them.

@geoand geoand marked this pull request as ready for review November 24, 2025 12:28
@gsmet
Copy link
Member

gsmet commented Nov 24, 2025

I added the entry: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.31 .

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call to revisit these values.

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 24, 2025
@Sanne
Copy link
Member Author

Sanne commented Nov 24, 2025

I added the entry: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.31 .

thanks! beat me to it :)

@quarkus-bot

This comment has been minimized.

@Sanne
Copy link
Member Author

Sanne commented Nov 24, 2025

looks like we have a bunch of integration tests verifying the default setting - I'll adjust them, please don't merge yet.

@Sanne
Copy link
Member Author

Sanne commented Nov 24, 2025

Adjusted the failing tests, and rebased

@quarkus-bot quarkus-bot bot added the area/jdbc Issues related to the JDBC extensions label Nov 24, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 24, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit e461265.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@gsmet
Copy link
Member

gsmet commented Nov 24, 2025

TBH, I don't see a lot of value in having these tests duplicated for each database type.

I suppose we can drop them next time we change the default value :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agroal area/jdbc Issues related to the JDBC extensions area/user-experience Will make us lose users triage/waiting-for-ci Ready to merge when CI successfully finishes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants