Prevent startup failing when having mismatched datasource types #51159
+242
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
|
/cc @gsmet (hibernate-orm) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lucamolteni
force-pushed
the
50634-bis
branch
from
b5cfbc9 to
36ee8d3
Compare
This comment has been minimized.
This comment has been minimized.
|
🎊 PR Preview 70552ed has been successfully built and deployed to https://quarkus-pr-main-51159-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
yrodiere
reviewed
Nov 24, 2025
Member
yrodiere
left a comment
yrodiere
left a comment
There was a problem hiding this comment.
Thanks! LGTM except for some comments that I had a hard time understanding, and of course the deprecation version that you mentioned in the PR's description.
...ent/src/main/java/io/quarkus/reactive/datasource/deployment/ReactiveDataSourceProcessor.java
Outdated
Show resolved
Hide resolved
Comment on lines
+16
to
+17
| // TODO Luca add deprecation version | ||
| @Deprecated(since = "version") |
Member
There was a problem hiding this comment.
Adding a comment here so that we don't merge this unfixed.
.../src/test/resources/application-unittest-both-named-reactive-and-default-blocking.properties
Show resolved
Hide resolved
...ate/reactive/compatibility/ORMReactiveCompatibilityNamedReactiveDefaultBlockingUnitTest.java
Outdated
Show resolved
Hide resolved
...ate/reactive/compatibility/ORMReactiveCompatibilityNamedReactiveDefaultBlockingUnitTest.java
Outdated
Show resolved
Hide resolved
...ibility/ORMReactiveCompatbilityDifferentNamedDataSourceNamedPersistenceUnitBothUnitTest.java
Show resolved
Hide resolved
...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java
Show resolved
Hide resolved
…en Hibernate ORM (blocking) and Hibernate Reactive by validating datasource configuration at build time. - Blocking persistence units are not created when only reactive datasources are configured - Reactive persistence units are not created when only blocking datasources are configured - Clear error messages are provided when datasources are missing - Created HibernateDataSourceUtil with shared datasource lookup logic - Extracted ReactiveDataSourceBuildItem to new `quarkus-reactive-datasource-spi` module to enable reactive data source checking in the Hibernate ORM extension - Refactored HibernateOrmProcessor and HibernateReactiveProcessor to validate datasource types and don't create the PU when there's no appropriate DS - Fail correctly when using a single extension but the datasource name is mismatched - Fixed ORMReactiveCompatbilityDifferentNamedDataSourceNamedPersistenceUnitBothUnitTest which was incorrectly passing due to dev services - Added new test cases for mixed datasource scenarios Fixes quarkusio#50634 quarkusio#47036
lucamolteni
force-pushed
the
50634-bis
branch
from
36ee8d3 to
82c6135
Compare
Status for workflow
|
yrodiere
approved these changes
Nov 24, 2025
Member
yrodiere
left a comment
yrodiere
left a comment
There was a problem hiding this comment.
LGTM! Please set the @Deprecated(since) and we're good to merge.
Member
|
Also please squash :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: needs deprecation version in original ReactiveDataSourceBuildItem
Prevent startup failing when having mismatched datasource types between Hibernate ORM (blocking) and Hibernate Reactive by validating datasource configuration at build time.
Blocking persistence units are not created when only reactive datasources are configured
Reactive persistence units are not created when only blocking datasources are configured
Clear error messages are provided when datasources are missing
Created HibernateDataSourceUtil with shared datasource lookup logic
Extracted ReactiveDataSourceBuildItem to new
quarkus-reactive-datasource-spimodule to enable reactive data source checking in the Hibernate ORM extensionRefactored HibernateOrmProcessor and HibernateReactiveProcessor to validate datasource types and don't create the PU when there's no appropriate DS
Fail correctly when using a single extension but the datasource name is mismatched
Fixed ORMReactiveCompatbilityDifferentNamedDataSourceNamedPersistenceUnitBothUnitTest which was incorrectly passing due to dev services
Added new test cases for mixed datasource scenarios