Skip to content

Enable VM Option -H:+ForeignAPISupport only for JDK 24 and AMD 64 #48446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

Enable VM Option -H:+ForeignAPISupport only for JDK 24 and AMD 64 #48446

merged 1 commit into from
Jun 19, 2025

Conversation

@IvanPetkov23
Copy link
Contributor

@IvanPetkov23 IvanPetkov23 commented Jun 18, 2025 •
edited by geoand
Loading

@geoand geoand requested a review from zakkak June 18, 2025 09:36
zakkak
zakkak approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @IvanPetkov23 !

@zakkak
Copy link
Contributor

zakkak commented Jun 18, 2025

CI testing the change with Mandrel for JDK 25 EA build: https://github.com/graalvm/mandrel/actions/runs/15729473941

Please don't merge before it completes.

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jun 18, 2025
@geoand
Copy link
Contributor

geoand commented Jun 18, 2025 •
edited
Loading

@zakkak https://github.com/graalvm/mandrel/actions/runs/15729473941/job/44328981038 seems to indicate a failure, or is that failure irrelevant?

@geoand geoand changed the title Enbable VM Option -H:+ForeignAPISupport only for JDK 24 and AMD 64 Enable VM Option -H:+ForeignAPISupport only for JDK 24 and AMD 64 Jun 18, 2025
Pankraz76
Pankraz76 reviewed Jun 19, 2025
View reviewed changes
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
*/
if ((graalVMVersion.compareTo(io.quarkus.runtime.graal.GraalVM.Version.VERSION_24_2_0) >= 0 && AMD64.active) ||
graalVMVersion.compareTo(io.quarkus.runtime.graal.GraalVM.Version.VERSION_25_0_0) >= 0) {
if (graalVMVersion.compareTo(io.quarkus.runtime.graal.GraalVM.Version.VERSION_24_2_0) == 0 && AMD64.active) {
Copy link

@Pankraz76 Pankraz76 Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (graalVMVersion.compareTo(io.quarkus.runtime.graal.GraalVM.Version.VERSION_24_2_0) == 0 && AMD64.active) {
if (graalVMVersion.compareTo(VERSION_24_2_0) == 0 && AMD64.active) {

could consider import afterwards.

@zakkak
Copy link
Contributor

zakkak commented Jun 19, 2025

@zakkak https://github.com/graalvm/mandrel/actions/runs/15729473941/job/44328981038 seems to indicate a failure, or is that failure irrelevant?

The failure is irrelevant.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 19, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 19, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 80704a1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@zakkak zakkak merged commit ba1b32a into quarkusio:main Jun 19, 2025
109 of 110 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 19, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 19, 2025
zakkak added a commit to zakkak/quarkus that referenced this pull request Jun 23, 2025
@zakkak
Fix condition for enabling -H:+ForeignAPISupport
c1de142 
Follow up to quarkusio#48446

Relates to quarkusio#48374
@zakkak zakkak mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zakkak zakkak zakkak approved these changes

+1 more reviewer

@Pankraz76 Pankraz76 Pankraz76 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/core area/native-image

Projects

None yet

Milestone

3.25.0.CR1

Development

Successfully merging this pull request may close these issues.

Don't pass -H:+ForeignAPISupport explicitely with GraalVM for JDK 25

4 participants

@IvanPetkov23 @zakkak @geoand @Pankraz76