-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Group redis integration tests into folder #47611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
ef65a46
to
49da776
Compare
By the way, is it intentional that we don't run |
This comment has been minimized.
This comment has been minimized.
49da776
to
465e7e0
Compare
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see where you're going from but:
redis-cache
is a separate extension- it's sometimes handy to look for all the devservices modules easily
But again, I could see how this new organization could be more practical in some cases.
Let's see what others think.
I nearly missed the fact that we had dev service tests for redis, because I expected them to be in the redis-client module. I think grouping the redis tests into a folder would (slightly) reduce scrolling in IDEs, and also make it slightly easier to see what tests we have.
WDYT?