-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Vert.x 4.5.12 and Netty 4.1.117.Final #45829
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
(just realised I've pushed the branch to the main repo and not my fork, apologies) |
Did you test the bindings? Is there any API change (revapi is going to give you the answer to that question :-)). @ozangunalp did you test on reactive messaging? |
The change looks good but let's wait for the CI and make sure we do not have regressions in the Mutiny bindings and Reactive Messaging. |
Reactive messaging is still on version 4.5.11 |
No the Mutiny bindings are on the previous version. |
It's green in the bindings CI |
I just built the compatibility report for the bindings - no breaking changes. |
This comment has been minimized.
This comment has been minimized.
Not sure about those failures, I'm doing a rebase + push to see what happens next. |
If you have to push again, let's close this PR and open a new one from your fork please because CI is running twice (once for |
Reactive messaging tests have passed. |
Coordinated upgrade to Vert.x 4.5.12 and Netty 4.1.117.Final