Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vert.x 4.5.12 and Netty 4.1.117.Final #45829

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jponge
Copy link
Member

@jponge jponge commented Jan 23, 2025

Coordinated upgrade to Vert.x 4.5.12 and Netty 4.1.117.Final

This comment was marked as resolved.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/netty area/vertx labels Jan 23, 2025
@jponge
Copy link
Member Author

jponge commented Jan 23, 2025

(just realised I've pushed the branch to the main repo and not my fork, apologies)

@geoand geoand requested a review from cescoffier January 23, 2025 15:01
@cescoffier
Copy link
Member

Did you test the bindings? Is there any API change (revapi is going to give you the answer to that question :-)). @ozangunalp did you test on reactive messaging?

@cescoffier
Copy link
Member

The change looks good but let's wait for the CI and make sure we do not have regressions in the Mutiny bindings and Reactive Messaging.

@ozangunalp
Copy link
Contributor

Reactive messaging is still on version 4.5.11

@jponge
Copy link
Member Author

jponge commented Jan 23, 2025

No the Mutiny bindings are on the previous version.

@jponge
Copy link
Member Author

jponge commented Jan 23, 2025

It's green in the bindings CI

@cescoffier
Copy link
Member

I just built the compatibility report for the bindings - no breaking changes.

This comment has been minimized.

@jponge
Copy link
Member Author

jponge commented Jan 24, 2025

Not sure about those failures, I'm doing a rebase + push to see what happens next.

@gsmet
Copy link
Member

gsmet commented Jan 24, 2025

If you have to push again, let's close this PR and open a new one from your fork please because CI is running twice (once for push and the other for pull_request) and a Vert.x update is very heavy on CI. Thanks!

@cescoffier
Copy link
Member

Reactive messaging tests have passed.

@jponge
Copy link
Member Author

jponge commented Jan 26, 2025

I'm checking the failing tests locally:

Native Tests - Security2
./mvnw verify -f integration-tests/oidc-client-wiremock -Pnative

Native Tests - Observability
./mvnw verify -f integration-tests/opentelemetry-redis-instrumentation -Pnative

Also the quickstarts CI job failed on building a report archive, but the Maven build was successful:

image

I'm tempted to say this PR is good, but I have no idea why the CI runs failed here on at least 2 runs, and at the very same places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants