Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable C2 for GraalVM as well in dev mode by default #45483

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Disable C2 for GraalVM as well in dev mode by default #45483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
505b228
Remove calls to System.out.println
aloubyansky Jan 9, 2025
539929a
Disable C2 for GraalVM as well in dev mode by default
aloubyansky Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/deployment/src/main/java/io/quarkus/deployment/dev/DevModeCommandLineBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,6 @@ public DevModeCommandLine build() throws Exception {

// if the --enable-preview flag was set, then we need to enable it when launching dev mode as well
if (devModeContext.isEnablePreview()) {
System.out.println("ADDING enable-preview");
jvmOptionsBuilder.add("enable-preview");
}

Expand Down Expand Up @@ -516,7 +515,7 @@ private boolean isDisableC2(Map<String, List<ArtifactKey>> lockedJvmOptions) {
extensionsEnableC2Warning(lockingExtensions);
return false;
}
return !JavaVersionUtil.isGraalvmJdk();
return true;
}

private void configureDebugging() throws Exception {
Expand Down
1 change: 0 additions & 1 deletion core/deployment/src/test/java/io/quarkus/deployment/dev/DevModeCommandLineBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ public void extensionSetsJvmOptionWoValue() throws Exception {
Set.of());

var args = getCliArguments(acmeMagic);
System.out.println(args);
assertThat(args).contains("--enable-preview");
}

Expand Down
Loading