Don't treat colon as a permission-to-action separator in @PermissionChecker value attribute #45364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PermissionsAllowed
and@PermissionChecker
simple, because:
can be used inside claims etc. without having a special meaning (like the permission-to-actions separator); see linked issue@PermissionChecker
@PermissionChecker
is just a plain character@PermissionsAllowed
and@PermissionChecker
values are matched based on a string equality, no actions exist@PermissionsAllowed
attributeinclusive
is set totrue
andread
is granted by a permission checker, then all theread:all
,read:whatever
inside same annotation instancevalue
also require a permission checker; this is important because normally it would be one permission, not 3 checkers and it adds complexity