Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC: optimize Instance injection points #45353

Merged

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 3, 2025

  • only collect InjectionPoint metadata if any of the resolved beans is dependent

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Jan 3, 2025
@mkouba
Copy link
Contributor Author

mkouba commented Jan 3, 2025

@geoand This should help with the problem mentioned in #45276. It would be great if you could test this pull request.

@mkouba mkouba requested review from Ladicek and manovotn January 3, 2025 14:03
@geoand
Copy link
Contributor

geoand commented Jan 3, 2025

@mkouba Thanks!

I assume I also have to make the beans in Quarkus REST @ApplicationScoped in order to see this having an effect?

@mkouba
Copy link
Contributor Author

mkouba commented Jan 3, 2025

@mkouba Thanks!

I assume I also have to make the beans in Quarkus REST @ApplicationScoped in order to see this having an effect?

That should not be necessary. Or at least not necessary for the optimization in this PR ;-).

@geoand
Copy link
Contributor

geoand commented Jan 3, 2025

Cool, let me check

@geoand
Copy link
Contributor

geoand commented Jan 3, 2025

Indeed the call to Reflections.findConstructor is gone, thanks!

@geoand
Copy link
Contributor

geoand commented Jan 3, 2025

When I have a little more time to poke around, I'll see if there are any other small quick wins that we can get

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 3, 2025
- only collect InjectionPoint metadata if any of the resolved beans is
dependent
@mkouba mkouba force-pushed the arc-instance-inject-metadata-optimize branch from 3d3cf1d to 34d9dd9 Compare January 3, 2025 16:15
Copy link

quarkus-bot bot commented Jan 3, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 34d9dd9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/kotlin-maven-invoker

io.quarkus.kotlin.maven.it.KotlinRemoteDevModeIT.testThatTheApplicationIsReloadedOnKotlinChange - History

  • org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes. - java.lang.RuntimeException
java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:86)
	at io.quarkus.kotlin.maven.it.KotlinRemoteDevModeIT.testThatTheApplicationIsReloadedOnKotlinChange(KotlinRemoteDevModeIT.java:23)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)

@geoand geoand merged commit f598fcb into quarkusio:main Jan 4, 2025
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 4, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants