-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openapi-swaggerui guide - reference MicroProfile OpenAPI Core configuration #43593
Conversation
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note to self - update spec link(s) when bumping to smallrye-open-api 4.0.
I'm all for merging this but do we also have a pointer for the annotations mentioned in #40007 (comment) ? |
@gsmet there is no reference for that in https://download.eclipse.org/microprofile/microprofile-open-api-3.1.1/microprofile-openapi-spec-3.1.1.html#_operation Spec html points also to https://github.com/eclipse/microprofile-open-api/wiki which and https://github.com/eclipse/microprofile-open-api/wiki/Annotation-Samples#operation-sample shows an example with So it's pretty hidden :) Pointer for the annotations mentioned in #40007 (comment) should be ideally in MicroProfile OpenAPI Specification document. |
Maybe a generic sentence saying that more information about the MicroProfile OpenAPI annotations can be found in the MicroProfile OpenAPI API Javadoc: https://download.eclipse.org/microprofile/microprofile-open-api-3.1.2/apidocs/org/eclipse/microprofile/openapi/annotations/package-summary.html . Not perfect but still better than nothing. And yes, I totally concur on the fact that it should be the MicroProfile OpenAPI doc containing this information. |
561d825
to
17c870c
Compare
PR updated |
Status for workflow
|
@gsmet good to go? |
Reference MicroProfile OpenAPI Core configuration