Limit overhead of capturing stacktrace in REST Client #42544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnaohara any chance you could test if this improves things? I didn't have time to profile (I'm on PTO :)) |
|
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
|
But we always capture the stack? Not only on errors? |
|
That's the only way to produce a meaningful stacktrace when an error occurs |
brunobat
reviewed
Aug 16, 2024
| String className = stackFrame.getClassName(); | ||
| return className.startsWith(RESTEASY_REACTIVE_PACKAGE) || className.contains(AUTOGENERATED_TAG); | ||
| } | ||
| }).limit(5).map(StackWalker.StackFrame::toStackTraceElement).toList(); |
There was a problem hiding this comment.
Is 5 lines enough?
this probably needs to be documented or add a config to keep the switch to the old behaviour.
There was a problem hiding this comment.
It's fine for identifying which REST Client is causing the problem and where it was called from.
It's not a complete stacktrace, but the complete one is mostly useless except for the top frames
This is done by utilizing the StackWalker API and limiting the number of frames captured Closes: quarkusio#42508
|
Let's close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by utilizing the StackWalker API
and limiting the number of frames captured