Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to COLLECTOR_OTLP_ENABLED env var for Jaeger #42542

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mabartos
Copy link
Contributor

@mabartos mabartos commented Aug 14, 2024

In the OTel Tracing guide, there is a reference to the COLLECTOR_OTLP_ENABLED env var, which should enable OTLP receivers. However, with regard to the more recent Jaeger all-in-one documentation, it should not be needed.

Also, the link to the blog does not properly reflect the present as it is already quite old and users should rather visit official OTel docs.

Could you please check this small improvement? Thanks!

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Copy link

quarkus-bot bot commented Aug 14, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 13ad91e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link

🎊 PR Preview 35f4c4a has been successfully built and deployed to https://quarkus-pr-main-42542-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@gsmet gsmet requested a review from brunobat August 14, 2024 16:11
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried the PR and the code does not work well...
For some reason the lates jaeger-all-in-one does not ingest the spans and causes errors on the exporter.
Can you please take a look?

@mabartos
Copy link
Contributor Author

@brunobat Sorry, I'll take a look at it this week. When I tried it, everything was working as expected, but I'll verify it once again.

@mabartos
Copy link
Contributor Author

@brunobat I tried to start the image all-in-one without the COLLECTOR_OTLP_ENABLED env var, and everything works properly in our Keycloak environment. All traces/spans are successfully exported to the Jaeger, as I can see them in the Jaeger UI.

BTW. is there any reason why the docker-compose is used in the guide as it uses only one service/image? Might it be probably better to put some docker/podman example?

@brunobat
Copy link
Contributor

We can replace it by a docker run... I can't remember a particular reason for the composer apart from the legibility.
Will not have bandwidth in the next 2 week.

@cescoffier
Copy link
Member

@brunobat Did you have the time to look at it?

@brunobat
Copy link
Contributor

Sorry, no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review pending
Development

Successfully merging this pull request may close these issues.

3 participants