-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reference to COLLECTOR_OTLP_ENABLED env var for Jaeger #42542
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Status for workflow
|
🎊 PR Preview 35f4c4a has been successfully built and deployed to https://quarkus-pr-main-42542-preview.surge.sh/version/main/guides/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried the PR and the code does not work well...
For some reason the lates jaeger-all-in-one does not ingest the spans and causes errors on the exporter.
Can you please take a look?
@brunobat Sorry, I'll take a look at it this week. When I tried it, everything was working as expected, but I'll verify it once again. |
@brunobat I tried to start the image BTW. is there any reason why the docker-compose is used in the guide as it uses only one service/image? Might it be probably better to put some docker/podman example? |
We can replace it by a docker run... I can't remember a particular reason for the composer apart from the legibility. |
@brunobat Did you have the time to look at it? |
Sorry, no. |
In the OTel Tracing guide, there is a reference to the
COLLECTOR_OTLP_ENABLED
env var, which should enable OTLP receivers. However, with regard to the more recent Jaeger all-in-one documentation, it should not be needed.Also, the link to the blog does not properly reflect the present as it is already quite old and users should rather visit official OTel docs.
Could you please check this small improvement? Thanks!