Add support for Url, Locale, Country Code and Currency scalars … #39942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
cristianonicolai
changed the title
jmartisk
reviewed
Apr 8, 2024
...eployment/src/main/java/io/quarkus/smallrye/graphql/deployment/SmallRyeGraphQLProcessor.java
Outdated
Show resolved
Hide resolved
cristianonicolai
force-pushed
the
scalars
branch
from
2ddf97e to
e87d979
Compare
gsmet
reviewed
Apr 10, 2024
Comment on lines
334
to
337
| extraScalars.forEach(extraScalar -> | ||
| Scalars.registerCustomScalarInSchema( | ||
| extraScalar.getGraphQLScalarType().getName(), | ||
| extraScalar.getValueClass().getName())); |
There was a problem hiding this comment.
I would avoid lambdas when they don't actually improve readability.
They have a cost.
We tend to avoid them mostly in the runtime part but really here, it's arguably making things less readable.
There was a problem hiding this comment.
sure, fixed.
Comment on lines
41
to
45
| extraScalars.forEach(extraScalar -> | ||
| GraphQLScalarTypes.registerCustomScalar( | ||
| extraScalar.getGraphQLScalarType().getName(), | ||
| extraScalar.getValueClass().getName(), | ||
| extraScalar.getGraphQLScalarType())); |
…raphql-java-extended-scalars
cristianonicolai
force-pushed
the
scalars
branch
from
e87d979 to
2f55b63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…from graphql-java-extended-scalars