Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared extension for the Hibernate Search Elasticsearch backend #39416

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Mar 13, 2024

To reduce code duplication.

Opening as draft, because:

Based on #43943, which must be merged first. => Done

@yrodiere yrodiere marked this pull request as draft March 13, 2024 16:59
@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/documentation area/hibernate-search Hibernate Search area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels Mar 13, 2024
Copy link

quarkus-bot bot commented Mar 13, 2024

/cc @gsmet (hibernate-search)

This comment has been minimized.

This comment has been minimized.

@yrodiere
Copy link
Member Author

yrodiere commented Oct 9, 2024

Rebased on main. Ran a few tests locally, and it seems to be working fine... we'll need to check the generated documentation for configuration properties though.

@yrodiere yrodiere marked this pull request as ready for review October 9, 2024 14:28

This comment has been minimized.

This comment has been minimized.

@yrodiere yrodiere force-pushed the backend-elasticsearch-shared branch from dcbbe40 to 1d3bb33 Compare October 9, 2024 14:58
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Oct 9, 2024

This comment has been minimized.

@yrodiere yrodiere force-pushed the backend-elasticsearch-shared branch 2 times, most recently from fb9e99c to 5bff5be Compare October 9, 2024 15:11

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement! 😃
There are a couple of failing tests because of the missing pu-config, I'll let you decide how you want to address those 😃. Other than that, it looks good!

@yrodiere yrodiere removed area/core triage/on-ice Frozen until external concerns are resolved area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/dependencies Pull requests that update a dependency file labels Oct 18, 2024

This comment has been minimized.

Copy link

github-actions bot commented Oct 18, 2024

🎊 PR Preview 7ab2138 has been successfully built and deployed to https://quarkus-pr-main-39416-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Oct 21, 2024
@yrodiere yrodiere changed the title [WIP] Shared extension for the Hibernate Search Elasticsearch backend Shared extension for the Hibernate Search Elasticsearch backend Oct 21, 2024
@yrodiere
Copy link
Member Author

#43943 was merged, I rebased on main, so I think we're all set.

@marko-bekhta I think I addressed your comments, do you mind approving please?

Copy link
Contributor

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gsmet
Copy link
Member

gsmet commented Oct 21, 2024

I'll have a look later today.

This comment has been minimized.

This comment has been minimized.

@yrodiere yrodiere added the triage/needs-review Issue that needs a review - remove label if all is clear label Oct 23, 2024
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the very late review. I added only one (annoying, sorry...) comment. I think it would be worth taking it into account even if I know you won't be very excited about it :).

Copy link
Member Author

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the extension to quarkus-hibernate-search-backend-elasticsearch-common as requested.

@yrodiere yrodiere requested a review from gsmet November 4, 2024 10:18
Copy link

quarkus-bot bot commented Nov 4, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 1c43f90.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Nov 4, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1c43f90.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/oidc-client-wiremock

io.quarkus.it.keycloak.OidcClientTest.testGetAccessTokenWithConfiguredExpiresIn - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.it.keycloak.OidcClientTest.testGetAccessTokenWithConfiguredExpiresIn(OidcClientTest.java:60)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/hibernate-search Hibernate Search triage/flaky-test triage/needs-review Issue that needs a review - remove label if all is clear
Projects
Development

Successfully merging this pull request may close these issues.

3 participants