-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new lines on file #36180
Fix new lines on file #36180
Conversation
Seems reasonable, but I want @phillip-kruger to verify nothing is wrong with the formatting |
Failing Jobs - Building be17fa4
Failures⚙️ Initial JDK 11 Build #- Failing: extensions/smallrye-openapi/deployment
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 197 more 📦 extensions/smallrye-openapi/deployment✖ |
Looks like the problem is actually in the class name as well... |
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
||
import io.quarkus.test.QuarkusUnitTest; | ||
import io.restassured.RestAssured; | ||
|
||
public class OpenApiRuntimeFilterTestCase { | ||
public class OpenApiRunTimeFilterTestCase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's weird, the class name is OpenApiRuntimeFilterTestCase
(lowercased t
)
This is caused by the sources not being in a case sensitive volume. See https://karnsonline.com/case-sensitive-apfs/ |
Mac M1 comes with a case insensitive filesystem. Java coding should only be done in a case sensitive filesystem. |
Not sure we should close this one, there is a regression that will hit other macOS users. |
AFAIK We should document the procedure to use a case sensitive filesystem, but that should be done in a separate PR, as this one isn't the correct fix |
Agreed, my point is really that having a case-insensitive macOS filesystem is (sadly) a common thing, so we shouldn't be in that situation. |
I would think Windows will have the same issues then? Let me have a look later today |
Class continues to show up as a change, even after a
git reset --hard upstream/main
The affected file seems to have come from here: #36152