Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new lines on file #36180

Closed
wants to merge 1 commit into from
Closed

Fix new lines on file #36180

wants to merge 1 commit into from

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Sep 27, 2023

Class continues to show up as a change, even after a git reset --hard upstream/main

The affected file seems to have come from here: #36152

@geoand
Copy link
Contributor

geoand commented Sep 27, 2023

Seems reasonable, but I want @phillip-kruger to verify nothing is wrong with the formatting

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 27, 2023

Failing Jobs - Building be17fa4

Status Name Step Failures Logs Raw logs Build scan
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/smallrye-openapi/deployment 
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 197 more

📦 extensions/smallrye-openapi/deployment

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project quarkus-smallrye-openapi-deployment: Compilation failure /home/runner/work/quarkus/quarkus/extensions/smallrye-openapi/deployment/src/test/java/io/quarkus/smallrye/openapi/test/jaxrs/OpenApiRuntimeFilterTestCase.java:[10,8] class OpenApiRunTimeFilterTestCase is public, should be declared in a file named OpenApiRunTimeFilterTestCase.java

@brunobat
Copy link
Contributor Author

brunobat commented Sep 27, 2023

Looks like the problem is actually in the class name as well...

import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;

import io.quarkus.test.QuarkusUnitTest;
import io.restassured.RestAssured;

public class OpenApiRuntimeFilterTestCase {
public class OpenApiRunTimeFilterTestCase {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird, the class name is OpenApiRuntimeFilterTestCase (lowercased t)

@gastaldi
Copy link
Contributor

This is caused by the sources not being in a case sensitive volume. See https://karnsonline.com/case-sensitive-apfs/

@brunobat
Copy link
Contributor Author

brunobat commented Sep 27, 2023

Mac M1 comes with a case insensitive filesystem. Java coding should only be done in a case sensitive filesystem.

@brunobat brunobat closed this Sep 27, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Sep 27, 2023
@jponge
Copy link
Member

jponge commented Sep 27, 2023

Not sure we should close this one, there is a regression that will hit other macOS users.

@gastaldi
Copy link
Contributor

AFAIK We should document the procedure to use a case sensitive filesystem, but that should be done in a separate PR, as this one isn't the correct fix

@jponge
Copy link
Member

jponge commented Sep 27, 2023

Agreed, my point is really that having a case-insensitive macOS filesystem is (sadly) a common thing, so we shouldn't be in that situation.

@phillip-kruger
Copy link
Member

I would think Windows will have the same issues then? Let me have a look later today

@brunobat brunobat deleted the fix-file branch October 17, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants