Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.junit:junit-bom from 5.9.3 to 5.10.0 #35518

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 23, 2023

Bumps org.junit:junit-bom from 5.9.3 to 5.10.0.

Release notes

Sourced from org.junit:junit-bom's releases.

JUnit 5.10.0 = Platform 1.10.0 + Jupiter 5.10.0 + Vintage 5.10.0

See Release Notes.

Full Changelog: junit-team/junit5@r5.10.0-RC2...r5.10.0

JUnit 5.10.0-RC2 = Platform 1.10.0-RC2+ Jupiter 5.10.0-RC2 + Vintage 5.10.0-RC2

See Release Notes.

JUnit 5.10.0-RC1 = Platform 1.10.0-RC1 + Jupiter 5.10.0-RC1 + Vintage 5.10.0-RC1

See Release Notes.

JUnit 5.10.0-M1 = Platform 1.10.0-M1 + Jupiter 5.10.0-M1 + Vintage 5.10.0-M1

See Release Notes.

Commits
  • 7f619ca Release 5.10
  • 9899de4 Update Gradle Enterprise plugin to 3.14
  • 45b970f Replace soon-to-be-deprecated usages of project.buildDir
  • 463ae36 Prune Release Notes for 5.10 GA
  • 893c64b Back to snapshots for further development
  • e6ff0c5 Release 5.10.0-RC2
  • b08a76b Add 5.10.0-RC2 release notes
  • 2c278c7 Revert "Prune Release Notes for 5.10 GA"
  • acb6e65 Provide access to source element annotations for TempDirFactory
  • 73818a1 Bump org.gradle.toolchains:foojay-resolver from 0.5.0 to 0.6.0
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @gastaldi.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Aug 23, 2023
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Aug 23, 2023
@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Sep 14, 2023

@holly-cummins should we upgrade to Junit 5.10? Looks like it doesn't break anything.

@gsmet
Copy link
Member

gsmet commented Sep 14, 2023

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.junit-junit-bom-5.10.0 branch from 568b115 to f670d8d Compare September 14, 2023 08:04
@holly-cummins
Copy link
Contributor

@holly-cummins should we upgrade to Junit 5.10? Looks like it doesn't break anything.

Yes, I think there's no reason not to. #34681 also does the same upgrade, but waiting for that PR to be fully baked could be a long wait. :)

@quarkus-bot

This comment has been minimized.

Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.9.3 to 5.10.0.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.9.3...r5.10.0)

---
updated-dependencies:
- dependency-name: org.junit:junit-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@Sanne Sanne force-pushed the dependabot/maven/org.junit-junit-bom-5.10.0 branch from f670d8d to d772d36 Compare September 19, 2023 12:39
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 19, 2023

Failing Jobs - Building d772d36

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 20 Build Failures Logs Raw logs Build scan

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 20 #

- Failing: extensions/reactive-oracle-client/deployment 
! Skipped: integration-tests/reactive-oracle-client 

📦 extensions/reactive-oracle-client/deployment

io.quarkus.reactive.oracle.client.DevServicesOracleDatasourceTestCase. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor#launchDatabases threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/gvenzl/oracle-free:23-slim-faststart

@gsmet gsmet merged commit 6a84c32 into main Sep 20, 2023
50 of 51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 20, 2023
@dependabot dependabot bot deleted the dependabot/maven/org.junit-junit-bom-5.10.0 branch September 20, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file kind/component-upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants