Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the non-default constructor mechanism of bytecode recording [2.13] #31212

Closed
wants to merge 4 commits into from
Closed

Fix the non-default constructor mechanism of bytecode recording [2.13] #31212

wants to merge 4 commits into from

Commits on Feb 16, 2023

  1. Fix the non-default constructor mechanism of bytecode recording 

    Bytecode recorders attempt to match constructor parameters to properties
and skip setting properties that were initialized by the constructor.
The assumption is that if the constructor has a parameter with the same
name as the property, the property is set by the constructor. Otherwise
it needs to be set using a setter.

This matching was not implemented for the non-default constructor mechanism.
This commit fixes that.
    @Ladicek @gastaldi
    Ladicek authored and gastaldi committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    c94ae9a View commit details
    Browse the repository at this point in the history

  2. Include test case for quarkusio#31153 

    Fix the test case for quarkusio#31153
    @gastaldi
    gastaldi committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    b600dc8 View commit details
    Browse the repository at this point in the history

  3. Optimize bytecode recording test performance 

    - Change creation of a large collection in `BytecodeRecorderTestCase.java` from using a loop to using `Collections.nCopies`
    @gastaldi
    gastaldi committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    8d48b43 View commit details
    Browse the repository at this point in the history

  4. Fix bytecode recorder matching of properties to constructor parameters 

    Bytecode recorders attempt to match properties to constructor parameters
by the property/parameter name. However, parameters do not always have
to have their names available. This commit fixes the bytecode recorder
matching mechanism to avoid parameters that do not have an available name.
    @Ladicek @gastaldi
    Ladicek authored and gastaldi committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    669fb80 View commit details
    Browse the repository at this point in the history