Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax testing constraints on certain dates tests #28044

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 19, 2022

These tests are not taking timezones properly into account, but they also don't really need to fully test the date handling, so we relax them a bit.

Closes: #28035

These tests are not taking timezones properly into account,
but they also don't really need to fully test the date handling,
so we relax them a bit.

Closes: quarkusio#28035
@quarkus-bot quarkus-bot bot added area/jackson Issues related to Jackson (JSON library) area/spring Issues relating to the Spring integration labels Sep 19, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 19, 2022

Failing Jobs - Building a6e79ff

Status Name Step Failures Logs Raw logs
Quickstarts Compilation - JDK 17 Compile Quickstarts Failures Logs Raw logs

Failures

⚙️ Quickstarts Compilation - JDK 17 #

- Failing: optaplanner-quickstart 

📦 optaplanner-quickstart

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project optaplanner-quickstart: Failed to build quarkus application

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, date/time handling is not the concern of these tests anyway. Also, java.time support in Hibernate ORM 5 is a bit complex, but should be better in ORM 6 from what I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jackson Issues related to Jackson (JSON library) area/spring Issues relating to the Spring integration kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hibernate ORM and Spring Data tests failing with out-by-one error when run on Mac in North American timezone
3 participants