Skip to content

Fallback to the default platform catalog if available registries do not provide any catalog #21339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

aloubyansky
Copy link
Member

Currently we are falling back to the default platform catalog (or suggesting user to do that manually) when we find that none of the configured registries is available.
However, today we had a case when the registry was returning its descriptor, indicating that it's available, but was failing to resolve the catalog artifacts. That would still be equivalent of the registry not being available, in which case we should also either fallback or suggest a workaround.

This change is adjusting the quarkus:create goal to fallback to the default platform if that happens.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Nov 10, 2021
@gsmet
Copy link
Member

gsmet commented Nov 10, 2021

If you want this in 2.5, please mark it for backport!

Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@geoand geoand requested a review from gastaldi November 10, 2021 16:00
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 10, 2021

Failing Jobs - Building a8edeea

Status Name Step Failures Logs Raw logs
Native Tests - Windows - hibernate-validator Build Failures Logs Raw logs

Failures

⚙️ Native Tests - Windows - hibernate-validator #

- Failing: integration-tests/hibernate-validator 

📦 integration-tests/hibernate-validator

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-hibernate-validator: Failed to build quarkus application

@geoand geoand merged commit 78ac67d into quarkusio:main Nov 11, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Nov 11, 2021
@gsmet gsmet modified the milestones: 2.6 - main, 2.5.0.Final Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants