[S1161] Add missing `@Override` to overriding and implementing methods

[Pankraz76]

@Override should be used on overriding members

While not mandatory, using the @Override annotation on compliant members (methods, properties, operators) improves readability by making it explicit that members are overridden.

Unlike other languages, all methods in Dart are virtual by default. So, using the @Override annotation prevents accidental overriding of a base class method in a subclass.

• https://sonarsource.github.io/rspec/#/rspec/S1161
• https://stackoverflow.com/questions/94361/when-do-you-use-javas-override-annotation-and-why/94411#94411

Implementation ideas

• https://docs.openrewrite.org/recipes/staticanalysis/missingoverrideannotation
  • [S1161] use staticanalysis.MissingOverrideAnnotation to avoid missing @Override on overriding and implementing methods #48344
• https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#missingoverride

[maxandersen]

"Unlike other languages, all methods in Dart are virtual by default."

How is Dart relevant to Java which is what we use?

If this is suggesting we are going to force @OverRide being added then I fail to see how that is going to be worth the annoyance/overhead.

[Pankraz76]

As im very stupid, always rely on big brother.

Its an dedicated sonar issue, begin set by sonar commite. Assuming you not part commite, we both not able to make discussion about this rule begin set. @gnodet suggested in mailing list its important. As its an easy to write "complain" code, at least for me was not problem to add this annotation, it should be simple for the high skilled dev team as well.

• https://docs.openrewrite.org/recipes/staticanalysis/missingoverrideannotation
• https://stackoverflow.com/a/94411
• https://www.tutorialspoint.com/importance-of-override-annotation-in-java

[Pankraz76]

annoyance

if dev´s write complain code, what should be expected, they will not notice at all, until corrupting, customer facing, software contract.

This is very big exception making PMD rule simple solution to prevent any further. To start being really consequent.

https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#missingoverride