-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making a CL parallel capable has a cost, should we revise our decision for QuarkusClassLoader? #42484
Comments
Another option is to do what we did in |
/cc @Sanne (core), @aloubyansky (core), @radcortez (core), @stuartwdouglas (core) |
I like that solution, it's a clever locking scheme which removes the need for the map and also makes it more efficient. I also think it could be improved more even (had some comments on the original PR), but even in its current form it's an improvement over the previous design. Awesome @gsmet that you're actively watching for such aspects! Love it, we need more of that. |
Please don't do it right away as there are a few other things going on here: #42525 |
Yeah, let's leave that for once all the critical stuff is in |
With #42525 in, we can no work on this |
We made
QuarkusClassLoader
parallel capable and this isn't cost free: theparallelLockMap
is more often than not close to 1 MB in memory size.While I don't have a problem with it if it actually makes things significantly faster, I think we should at least check if it's the case.
See here (sorry the selected line is not the right one but it's easy to find it):
The text was updated successfully, but these errors were encountered: