Quarkus redirects lost traces

[ukrcoder]

Describe the bug

Using quarkus 3.4.3 and latest opentelemetry there. I want whole my flow be linked and to see it inside zipkin/jaeger (no matter). But when I have redirects in my code -> than I'll always have separate track and new traceId flow.

I cannot always pass traceparent header because of ui (in that case secured cookies could be used so I can store state). But adding as a header doesn't help to link to the parent.

Tried to add parent to the context with next code
`String[] values = traceparentCookie.split("-");

    SpanContext parentContext = SpanContext.create(values[1], values[2], TraceFlags.getSampled(), TraceState.getDefault());
    Span parentSpan = Span.wrap(parentContext);
    Log.infof("TRACEPARENT DATA: trace is = " + values[1] + " and span is = " + values[2]);

    Span span = tracer.spanBuilder("ui-provider-picker").setParent(Context.current().with(parentSpan)).startSpan();
    try (Scope scope = span.makeCurrent()) {
    } finally {
        span.setAttribute("test", "12345");
        span.end();
    }`

it creates new span and attaches to base process as a last one and then starts new trace with needed me endpoint. It's also created as an empty one without tags or any info.

Overall what I want: to link one span with another one retrieving all needed tags. Couldn't find solution meanwhile.
Any suggestions?

Expected behavior

Expected linked flow of multiple actions on redirect.

Actual behavior

Additional span inside main flow and new trace and span for redirected action

How to Reproduce?

 @GET
    public Uni<RestResponse<Void>> test() {
        try {
            URI uri = new URI("http://localhost:8080/ui");
            RestResponse.ResponseBuilder<Void> objectResponseBuilder = RestResponse.ResponseBuilder.seeOther(uri);
            return Uni.createFrom().item(objectResponseBuilder.build());
        } catch (URISyntaxException e) {
            throw new URLParserException(e);
        }
    }

"http://localhost:8080/ui" - will be added as a new trace in zipkin.

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @brunobat (opentelemetry,tracing), @radcortez (opentelemetry,tracing)

[geoand]

Can you please attach a sample application that behaves as you describe?

Thanks

[denysandriyanov]

@geoand reproducer.zip

to reproduce the issue:

1. run Zipkin container - docker-compose -f zipkin-otel-compose.yml up
2. run dummy service
3. do GET /oauth2/login - it will redirect to /oauth2/login/another
4. Open Zipkin http://localhost:9411/
5. Click Run Query to refresh

Actual result: 2 items will appear in the results

Expected: 1 item with 2 requests

[ukrcoder]

@geoand reproducer.zip

to reproduce the issue:

1. run Zipkin container - docker-compose -f zipkin-otel-compose.yml up
2. run dummy service
3. do GET /oauth2/login - it will redirect to /oauth2/login/another
4. Open Zipkin http://localhost:9411/
5. Click Run Query to refresh

Actual result: 2 items will appear in the results

Expected: 1 item with 2 requests

yes, please use this project as a reference how to reproduce.

Any thoughts on this?

Thanks,
Anton

[geoand]

Thanks.

I am traveling so I have not had time to look into it.

[denysandriyanov]

If this is not considered as a bug. Could we have a suggestion on the business case. When executing OAuth2 code grant flow it requires a bunch of redirects. We want to have all the flow requests spans under one trace, how it can be achieved?

[geoand]

I am not really clear on which spans you would like to have be part of the same parent span. Care to elaborate please?

[ukrcoder]

Well, if you see comment above there is a screenshot and there are 2 traces - we want it to be under same trace. But if we have redirect it creates new span and new trace and this we can not link to first trace.

[denysandriyanov]

I am not really clear on which spans you would like to have be part of the same parent span. Care to elaborate please?

I appreciate your response. To elaborate further on the issue at hand:

The scenario involves an initial request directed to the /login endpoint, followed by a subsequent redirection to the /login/other endpoint. This sequential flow generates separate trace IDs for each request, leading to the creation of distinct traces. The primary objective is to consolidate these requests under a single trace ID while establishing a relationship where the /login/other request is a child span of the /login span.

The challenge we're facing is the need to set the parent span ID and trace ID somehow before the trace initialization to ensure that both endpoints contribute to a unified trace. The current method generates two separate traces:

The trace initiated during request initialization, which lacks the required trace ID and parent ID linkage.
The trace created through subsequent manipulation, containing the desired trace ID and parent span ID but lacking essential information from the initial trace.
The goal remains to correctly link these spans under one trace while maintaining the parent-child relationship between the /login and /login/other spans. We're exploring strategies to set the context beforehand, preventing the creation of separate traces and ensuring proper linkage within a unified trace.

May be there is some way we can intercept/filter request before span context is set and set it with our values of traceId and parent trace id? Or may be there are some headers we can set that quarkus will read and understand that there is not standalone/new request but rather a part of the other flow and will use data from headers accordingly to set traceId and parent spanId?

Your insights on how to effectively manage this tracing scenario would be greatly appreciated.

[geoand]

I just ran this myself and now I see exactly what you mean.

To be honest I am not sure how OpenTelemetry is meant to be used in these cases, so I let @brunobat answer