Qute: Self-closing tag does nothing

[kucharzyk]

Describe the bug

This tag works

{#validation field='general'}{/validation}

If I try using self-closing tag like this it does nothing

{#validation field='general'/}

Nothing is rendered. No error reported by qute

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @mkouba

[mkouba]

Hm, both variants should work and are tested. We'll need a reproducer or more information...

[kucharzyk]

@mkouba I've created a reproducer. From tests everything works ok.

https://github.com/kucharzyk/self-closing-tag/blob/main/src/main/resources/templates/page.qute.html

There is a problem when tag is used in include section

{#include base}
<main>
    <div>
        <b>A) START</b>{#validation field='general'}{/validation}<b>END</b>
    </div>

    {!<div>!}
        {!<b>B) START</b>{#validation field='general'/}<b>END</b>!}
    {!</div>!}
</main>
{/include}

It is rendered without errors as A) STARTEND

If you comment section A and uncomment section B you got only B) START - some of content is missing

But when you uncomment them both you will see why this is happening:

#1 Multiple blocks define the content for the insert section 'validation' in template page.qute.html

[mkouba]

@kucharzyk What does the base template look like? It seems that there is a conflict between an insert section and your tag.

[kucharzyk]

@mkouba You have this base template in repository

https://github.com/kucharzyk/self-closing-tag/blob/main/src/main/resources/templates/base.html

[mkouba]

@mkouba You have this base template in repository

https://github.com/kucharzyk/self-closing-tag/blob/main/src/main/resources/templates/base.html

Ok, let me check the reproducer...

[mkouba]

So the reason why it does not report an error is that {#include} treats all unknown sections as extending blocks. And multiple extending blocks of the same name result in Multiple blocks define the content. We don't validate the included template (base.html) because it does not have to exist yet - it's included at runtime.

[mkouba]

We should definitely improve the validation and fail the template initialization if an {#insert} section conflicts with an existing section/tag. But that won't help with this particular case.