Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A list of non Red Hat version artifacts for redhat-version-rate option #341

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Jul 25, 2024

A list of non Red Hat version artifacts for redhat-version-rate option

Introduces --log-not-matched option that can be used in the future in combination with other options than just --redhat-version-rate.

Example command: domino quarkus --version 3.8.5.SP1-redhat-00001 --members=quarkus-bom --redhat-version-rate --extension-versions='*redhat*' --log-not-matched

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea makes sense but I'd like to apply two adjustments.

  1. There is nothing redhat-specific in the user interface so far and ideally we should keep it that way, imo. That means this option should probably mean what was filtered out based on the filtering expressions provided by the user.
  2. 'verbose' is too generic as a name. I'd prefer something like 'log-not-matched' or similar/better.

WDYT?

@rsvoboda
Copy link
Member Author

There is nothing redhat-specific

we have --redhat-version-rate ...

and log message like this:

Artifacts with Red Hat versions : 880 (81.6%)

Is the original comment about Non Red Hat version artifacts: string? Or anything else?

log-not-matched

I'm not sure, because the main option is --redhat-version-rate Calculate the rate of redhat versions among the inspected dependencies so there is no explicit search. But still --log-not-matched is probably better as it's more specific than --verbose I will change the option name.

@rsvoboda
Copy link
Member Author

Update with "--log-not-matched" change

@aloubyansky
Copy link
Member

Right, sorry, I confused it with a different option. Thanks, i'll have another look.

@aloubyansky aloubyansky merged commit d4e71b8 into quarkusio:main Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants