Escape exclamation mark escaping when creating a zip file #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postremus
reviewed
Oct 2, 2024
There was a problem hiding this comment.
LGTM
AFAIR, this only happens because the ! is a marker to indicate that / is a path inside a jar.
Could you please add a test, where you excersice different combinations including !, and other characters normally needing to be escaped in URLs? (like + ? # etc)
|
TBH, that's how far I'm willing to go to fix this corner case :). I tested things with the original report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes quarkusio/quarkus#43273