Skip to content

Conversation

Fenrisfulsur
Copy link
Collaborator

Fix the JumpNb feature by replacing mnemonic check with capstone group check

@Fenrisfulsur Fenrisfulsur requested a review from RobinDavid May 20, 2024 10:09
@Fenrisfulsur Fenrisfulsur mentioned this pull request May 20, 2024
@patacca
Copy link
Collaborator

patacca commented May 21, 2024

Thanks for the contribution, I just changed two things:

  • avoid importing modules when needed only for type hints, instead import them under the if TYPE_CHECKING condition. This has not been enforced on the entire code base yet but let's try to avoid this practice on the new code
  • Wrap the casting from capstone group into a specific method, this should help for code reuse and it can centralize the conversion from capstone into a single place. If in the future we will have misalignment issues it will be easier to address them.

Beside this LGTM!

@patacca patacca merged commit fcd37f9 into main May 21, 2024
@patacca patacca deleted the fix-jumb_nb-feature branch May 21, 2024 12:31
@patacca patacca mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants