fix: set most reasonable defaults

quarkiverse · Nov 14, 2023 · 44a6aad · 44a6aad
1 parent eb22567
commit 44a6aad
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/deployment/src/main/java/io/quarkiverse/wiremock/devservice/WireMockServerConfig.java b/deployment/src/main/java/io/quarkiverse/wiremock/devservice/WireMockServerConfig.java
@@ -21,7 +21,7 @@ public interface WireMockServerConfig {
      * Indicates whether WireMock server needs to be restarted after Quarkus live reload (see development mode for more
      * information) or not.
      */
-    @WithDefault("false")
+    @WithDefault("true")
     boolean reload();
 
     /**

diff --git a/deployment/src/test/java/io/quarkiverse/wiremock/devservice/WireMockDevModeTest.java b/deployment/src/test/java/io/quarkiverse/wiremock/devservice/WireMockDevModeTest.java
@@ -16,6 +16,7 @@
 import io.restassured.RestAssured;
 
 // Write your dev mode tests here - see the testing extension guide https://quarkus.io/guides/writing-extensions#testing-hot-reload for more information
+@SuppressWarnings("java:S5786")
 public class WireMockDevModeTest {
     private static final int DEV_MODE_PORT = 9099;
     private static final int DEV_MODE_PORT_MODIFIED = 9100;
@@ -28,10 +29,9 @@ public class WireMockDevModeTest {
                     .addAsResource(APP_PROPERTIES));
 
     @Test
-    public void testPortMappingViaLiveReload() {
+    void testPortMappingViaLiveReload() {
         assertTrue(isPortInUse(DEV_MODE_PORT), "WireMock DevService doesn't listen on port " + DEV_MODE_PORT);
 
-        RestAssured.get(BASE_URL + "/reload").then().body(equalTo("true"));
         DEV_MODE_TEST.modifyResourceFile(APP_PROPERTIES,
                 s -> s.replace("devservices.port=" + DEV_MODE_PORT, "devservices.port=" + DEV_MODE_PORT_MODIFIED));
 

diff --git a/deployment/src/test/resources/application.properties b/deployment/src/test/resources/application.properties
@@ -1,4 +1,3 @@
-%dev.quarkus.wiremock.devservices.reload=true
 # The short form notation leads to a warning that the property 'quarkus.wiremock.devservices.port' is unknown. This is most likely a bug Quarkus and should be reported upstream.
 #%dev,test.quarkus.wiremock.devservices.port=9099
 %dev.quarkus.wiremock.devservices.port=9099

diff --git a/docs/modules/ROOT/pages/includes/quarkus-wiremock.adoc b/docs/modules/ROOT/pages/includes/quarkus-wiremock.adoc
@@ -53,7 +53,7 @@ ifndef::add-copy-button-to-env-var[]
 Environment variable: `+++QUARKUS_WIREMOCK_DEVSERVICES_RELOAD+++`
 endif::add-copy-button-to-env-var[]
 --|boolean
-|`false`
+|`true`
 
 a|icon:lock[title=Fixed at build time] [[quarkus-wiremock_quarkus.wiremock.devservices.files-mapping]]`link:#quarkus-wiremock_quarkus.wiremock.devservices.files-mapping[quarkus.wiremock.devservices.files-mapping]`
 

diff --git a/docs/modules/ROOT/pages/index.adoc b/docs/modules/ROOT/pages/index.adoc
@@ -28,7 +28,7 @@ Example (default) configuration for testing and local development:
 [source,properties]
 ----
 %dev,test.quarkus.wiremock.devservices.enabled=true
-%dev,test.quarkus.wiremock.devservices.reload=false
+%dev,test.quarkus.wiremock.devservices.reload=true
 %dev,test.quarkus.wiremock.devservices.files-mapping=src/test/resources
 %dev,test.quarkus.wiremock.devservices.port=8089
 %dev,test.quarkus.wiremock.devservices.global-response-templating=false