Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#482 Support for application/problem+json deserialization for RestClients #483

Merged
merged 8 commits into from
Apr 4, 2025

Conversation

lwitkowski
Copy link
Collaborator

@lwitkowski lwitkowski commented Apr 3, 2025

Changes

Closes #482, closes #429, related to #473

@lwitkowski lwitkowski force-pushed the feat/problem-deserializer branch 2 times, most recently from 50e1bf5 to dcd0228 Compare April 3, 2025 19:17
@lwitkowski lwitkowski force-pushed the feat/problem-deserializer branch from dcd0228 to 97d561e Compare April 3, 2025 19:18
…, some renaming, better tests, simpler gateway-upstreamapi setup
…ice to another and error happens on backend
@lwitkowski lwitkowski force-pushed the feat/problem-deserializer branch from fcc4501 to 4b80006 Compare April 4, 2025 10:26
@lwitkowski lwitkowski marked this pull request as ready for review April 4, 2025 10:30
@lwitkowski
Copy link
Collaborator Author

lwitkowski commented Apr 4, 2025

In the fix for #429 I still decided to pass all headers except the one that caused issue ('content-length'), but the more I think about it the more I believe this extension should not pass any header by default (mainly for safety reasons, but it may be also error-prone).

Maybe we should introduce quarkus.resteasy.problem.proxy-pass-header config option (default empty) with explicit list of headers developers decide they want to pass from upstream service to gateway clients. In both scenarios (with ThrowingHttpProblemClientExceptionMapper and without).

WDYT?

edit: I've extracted this topic to #485, I suggest we continue the discussion over there.

Copy link
Collaborator

@pazkooda pazkooda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside one minor thing look really good!

@lwitkowski
Copy link
Collaborator Author

lwitkowski commented Apr 4, 2025

Beside one minor thing look really good!

Thanks man, would you mind having a look at this comment? #483 (comment)

edit: followed up #485

@lwitkowski lwitkowski changed the title #422 Support for application/problem+json deserialization for RestClients #482 Support for application/problem+json deserialization for RestClients Apr 4, 2025
Copy link

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@melloware
Copy link

I have archived my Repo and left a note saying that all features have been ported into this extension:
https://github.com/melloware/quarkus-openapi-problem

image

@lwitkowski lwitkowski merged commit e398e46 into main Apr 4, 2025
9 checks passed
@lwitkowski lwitkowski deleted the feat/problem-deserializer branch April 4, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants