-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#482 Support for application/problem+json deserialization for RestClients #483
Conversation
50e1bf5
to
dcd0228
Compare
dcd0228
to
97d561e
Compare
…, some renaming, better tests, simpler gateway-upstreamapi setup
8fd52f2
to
125ae79
Compare
…ice to another and error happens on backend
fcc4501
to
4b80006
Compare
In the fix for #429 I still decided to pass all headers except the one that caused issue ('content-length'), but the more I think about it the more I believe this extension should not pass any header by default (mainly for safety reasons, but it may be also error-prone). Maybe we should introduce WDYT? edit: I've extracted this topic to #485, I suggest we continue the discussion over there. |
...ime/src/main/java/io/quarkiverse/resteasy/problem/jackson/JacksonProblemModuleRegistrar.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside one minor thing look really good!
Thanks man, would you mind having a look at this comment? #483 (comment) edit: followed up #485 |
...me/src/test/java/io/quarkiverse/resteasy/problem/jackson/JacksonProblemDeserializerTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
I have archived my Repo and left a note saying that all features have been ported into this extension: |
Changes
HttpProblem
HttpProblem
ThrowingHttpProblemClientExceptionMapper
for RestClients to deserializeapplication/problem+json
and throw asHttpProblem
Closes #482, closes #429, related to #473