-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#38] Add instance
default value
#39
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
353203c
to
06a3588
Compare
This comment has been minimized.
This comment has been minimized.
06a3588
to
eb05637
Compare
This comment has been minimized.
This comment has been minimized.
eb05637
to
d090e29
Compare
This comment has been minimized.
This comment has been minimized.
instance
default value
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved (with one comment - could be fixed later).
|
||
Problem enhancedProblem = processor.apply(originalProblem, simpleContext()); | ||
|
||
assertThat(enhancedProblem.getInstance()).hasPath("/endpoint"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite not-self-contained test :(.
Why I need to go outside of this class to understand why path has /endpoint
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True that, will address that in separate PR, where I already have made some changes to this class.
For explanation 'why' refer to #38
Changes in this PR from end user point of view:
NotFoundException
thrown from/country/pl
:Before:
After:
What is important is that adding default values happens after problem is logged to console. This means type and instance fields are not logged, otherwise it could lead to personal info (like ssn sent as path param) being logged, which is usually not a good idea.
Closes #38