Skip to content

feat(impl): Support interception of output record before serialization #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

edeweerd1A
Copy link
Contributor

Fixes #147.

Introduction of a new OutputRecordInterceptor interface to be implemented to be able to intercept outgoing messages before their payload is serialized. Its aim is to replace the ProducerOnSendInterceptor that at the difference with OutputRecordInterceptor is called after the serialization of the payload. Henceforth ProducerOnSendInterceptor is deprecated.

Version is bumped to 4.1 to reflect the new feature. It is backwards-compatible.

The TracingProducerInterceptor has been rewritten as a TracingOutputRecordInterceptor, but kept for backwards-compatibility. It is itself marked for removal as well.

Documentation updated accordingly.

@edeweerd1A edeweerd1A requested a review from a team as a code owner February 28, 2025 13:23
@edeweerd1A edeweerd1A force-pushed the output-record-interception branch 3 times, most recently from 0e0889e to ff2ca27 Compare February 28, 2025 14:54
Copy link
Contributor

@flazarus1A flazarus1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Fixes quarkiverse#147.

Introduction of a new `OutputRecordInterceptor` interface to be implemented to be able to intercept outgoing messages before their payload is serialized.
Its aim is to replace the `ProducerOnSendInterceptor` that at the difference with `OutputRecordInterceptor` is called after the serialization of the payload.
Henceforth `ProducerOnSendInterceptor` is deprecated.

Version is bumped to 4.1 to reflect the new feature.
It is backwards-compatible.

The TracingProducerInterceptor has been rewritten as a TracingOutputRecordInterceptor, but kept for backwards-compatibility.
It is itself marked for removal as well.

Documentation updated accordingly.
@edeweerd1A edeweerd1A force-pushed the output-record-interception branch from ff2ca27 to 24fe5d3 Compare March 3, 2025 15:30
@edeweerd1A edeweerd1A merged commit 5412571 into quarkiverse:main Mar 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interception of records before serialization
3 participants