Skip to content

Conversation

@mhucka
Copy link
Collaborator

@mhucka mhucka commented Jan 6, 2026

There was an inconsistency in the Makefiles versus tests/BUILD and tests/make.sh, in that a couple of the Makewfiles used -msse4.1 while the BUILD file and tests/make.sh used -msse4. In addition, it seems that -msse4 subsumes -msse4.1, and so overall, it appears better to use -msse4.

Fixes #892.

@github-actions github-actions bot added the Size: XS <10 lines changed label Jan 6, 2026
@mhucka mhucka changed the title Use -msse4 rather than -msse4.1 in Makefiles Fix #892: use -msse4 rather than -msse4.1 in Makefiles Jan 6, 2026
@mhucka mhucka marked this pull request as ready for review January 6, 2026 05:07
@mhucka mhucka requested a review from sergeisakov January 6, 2026 05:15
@mhucka mhucka enabled auto-merge January 6, 2026 05:15
@mhucka mhucka added this pull request to the merge queue Jan 6, 2026
Merged via the queue into quantumlib:main with commit 1438bad Jan 6, 2026
28 checks passed
@mhucka mhucka deleted the mh-fix-892 branch January 6, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSE and SSE4 are not equivalent

2 participants