Skip to content

Update submodule googletest to latest version #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 27, 2025
Merged

Update submodule googletest to latest version #713

merged 3 commits into from
May 27, 2025

Conversation

mhucka
Copy link
Collaborator

@mhucka mhucka commented May 23, 2025 •
edited
Loading

This is a straightforward application of

git submodule update --remote --merge

@mhucka mhucka self-assigned this May 24, 2025
@mhucka mhucka requested review from pavoljuhas and dstrain115 May 24, 2025 01:47
@mhucka mhucka marked this pull request as ready for review May 24, 2025 01:47
@mhucka mhucka added area/devops Involves build systems, Make files, Bazel files, continuous integration, and or other DevOps topics area/health Involves general matters of project configuration, health, maintenance, and similar concerns area/dependencies Involves packages or other software that qsim depends on area/tests Involves test cases, test frameworks, and similar labels May 24, 2025
pavoljuhas
pavoljuhas approved these changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided this does not break tests.

@mhucka mhucka merged commit 5c6bb69 into master May 27, 2025
14 of 19 checks passed
@mhucka mhucka deleted the mh-update-googletest branch May 27, 2025 23:04
mhucka added a commit to mhucka/qsim that referenced this pull request May 30, 2025
@mhucka
Update submodule googletest to latest version (quantumlib#713)
3c16c35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@dstrain115 dstrain115 Awaiting requested review from dstrain115

Assignees

@mhucka mhucka

Labels
area/dependencies Involves packages or other software that qsim depends on area/devops Involves build systems, Make files, Bazel files, continuous integration, and or other DevOps topics area/health Involves general matters of project configuration, health, maintenance, and similar concerns area/tests Involves test cases, test frameworks, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhucka @pavoljuhas