Skip to content

VERSION_INFO is set in setup.py but never used anywhere #979

@mhucka

Description

@mhucka

What is the task?

In setup.py, there is code to define a compile-time variable VERSION_INFO:

qsim/setup.py

Lines 111 to 115 in d913ad7

env = os.environ.copy()
cxxflags = env.get("CXXFLAGS", "")
env["CXXFLAGS"] = (
f'{cxxflags} -DVERSION_INFO=\\"{self.distribution.get_version()}\\"'
)

However, a search of the code base reveals VERSION_INFO is not used anywhere:

Image

We can remove this dead code and simplify setup.py.

(Optional) Do you have ideas or preferences for the approach?

No response

How urgent is this for you?

None

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/healthInvolves general matters of project configuration, health, maintenance, and similar concernsarea/pythonInvolves the Python code in qsim

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions