remove macos-13 from workflows and update the type stub to accommodate the latest numpy version #79
Conversation
mhucka
left a comment
mhucka
left a comment
There was a problem hiding this comment.
Looks good, but check the changes to tunits/core/init.pyi as they don't appear to be related to macos-13.
| real: 'Value' | ||
| imag: 'Value' | ||
|
|
||
| # needed because np.generic declars __new__ as abstract. |
There was a problem hiding this comment.
You're welcome to handle PRs as you wish, of course, but I wanted to flag this in case it was included accidentally: this looks like an unrelated change. (Unrelated to removing macos-13.)
There was a problem hiding this comment.
without this the CI is broken because of a recent update to numpy ... numpy now declares new as an abstract method which it didn't used to do.
There was a problem hiding this comment.
this is why the commit that added this change is called "fix mypy"
There was a problem hiding this comment.
Right, but what I'm trying to say is, that change should probably be done as a separate PR, rather than being a part of this PR.
There was a problem hiding this comment.
I update the title and description ... small fixes to the CI can be interwoven into PRs
NoureldinYosri
changed the title
2 participants
fixes #78 and updates the type stub to accommodate the breaking change introduced in the latest numpy release