Skip to content

Fix typo in recirq/cluster_state_mipt/README.md #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 20, 2025

Conversation

WandaHou
Copy link
Contributor

@WandaHou WandaHou commented Jul 11, 2025

I fixed a typo in recirq/cluster_state_mipt/README.md:

The two qubit gate description should be: $Z_j^{-1/2}Z_k^{-1/2}\mathrm{CZ}{jk}$ not $\mathrm{CZ}{jk}Z_j^{-1/2}Z_k^{-1/2}$ as described in the main text.

@WandaHou
Copy link
Contributor Author

@dstrain115 Hi, I fixed a typo in README, nothing else. Thanks.

@mhucka
Copy link
Contributor

mhucka commented Jul 11, 2025

@WandaHou Thank you for your contribution. I'd like to offer some quick feedback for best practices involving pull requests:

  • Could you make the title more descriptive? It would help future readers if the title could be something along the lines of, for example, "Fix typo in recirq/cluster_state_mipt/README.md". (There is more than one README file in the project.)

  • Please include a description in the PR; don't leave it empty.

@mhucka
Copy link
Contributor

mhucka commented Jul 11, 2025

Regarding the check failure, it's not because of the change in this PR. We'll investigate what's happening here.

@WandaHou WandaHou changed the title fixed a typo in README Fix typo in recirq/cluster_state_mipt/README.md Jul 11, 2025
@WandaHou
Copy link
Contributor Author

@WandaHou Thank you for your contribution. I'd like to offer some quick feedback for best practices involving pull requests:

  • Could you make the title more descriptive? It would help future readers if the title could be something along the lines of, for example, "Fix typo in recirq/cluster_state_mipt/README.md". (There is more than one README file in the project.)
  • Please include a description in the PR; don't leave it empty.

Thanks, I updated the title and also add a comment at the top. Is this the PR you refering to?

@mhucka
Copy link
Contributor

mhucka commented Jul 11, 2025

Thanks, I updated the title and also add a comment at the top. Is this the PR you refering to?

Yes, this one. Thanks!

@mhucka
Copy link
Contributor

mhucka commented Jul 17, 2025

@WandaHou My apologies for how long this is taking. The CI failures involve NumPy 2 compatibility, and while most were easy to fix, there is one that has remained a stumper. Issue #396 describes it.

I have a PR now (PR #397); once it's passed review and has been merged into the ReCirq main branch, the CI tests here on GitHub should succeed and we will be able to merge your PR.

@mhucka mhucka self-assigned this Jul 17, 2025
@mhucka mhucka enabled auto-merge (squash) July 20, 2025 04:13
@mhucka mhucka merged commit 7601a40 into quantumlib:master Jul 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants