[QGFPoly] Add GF2PolyAddK, GFPolySplit and GFPolyJoin bloqs
#1622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
changed the title
GF2PolyAddK, GFPolySplit and GFPolyJoin bloqs
|
@NoureldinYosri I've added tests for gate counts, as you had pointed out in the review for the bigger PR. Can you LGTM this first so I can merge this first, rebase the second PR, and then merge that as well ? |
NoureldinYosri
approved these changes
Apr 8, 2025
wjhuggins
pushed a commit
to wjhuggins/Qualtran
that referenced
this pull request
May 31, 2025
…antumlib#1622) * Add GF2PolyAddK, GFPolySplit and GFPolyJoin bloqs * Fix tests, mypy and pylint * Mark symbolic only when degree is symbolic * Add tests for gate counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a larger effort to add bloqs that perform arithmetic over polynomials with coefficients in a galois field.
Adds bloqs for
GFPolySplit: Split a register of typeQGFPolyinton + 1registers of typeQGFwherenis the degree of the polynomial.GFPolyJoin: Joinn + 1registers of typeQGF, wherenis the degree of the polynomial, into a register of typeQGFPoly.GF2PolyAddK: Bloq to add a constant polynomial into a quantum register of typeQGFPoly.