Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify QubitizationWalkOperator: remove specializations for control/adjoint and use defaults instead #1481

Merged
merged 18 commits into from
Nov 4, 2024
Merged

Simplify QubitizationWalkOperator: remove specializations for control/adjoint and use defaults instead #1481

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
99748ed
simplify walk operator
anurudhp Oct 28, 2024
e9e491e
add ctrl systems for various bloqs
anurudhp Oct 28, 2024
5ea723a
special adjoint wrapper for bloqs with specialized ctrl
anurudhp Oct 29, 2024
6248dbe
fix ctrl sys for `CZ` and `CY`: target register names of uncontrolled…
anurudhp Oct 29, 2024
1df30f6
nb
anurudhp Oct 29, 2024
af72c1d
fix bug in select hubbard (`0` ctrl not supported by decomp, so fallb…
anurudhp Oct 29, 2024
863fef1
move new adjoint bloq to `mcmt.specialized_ctrl`
anurudhp Oct 30, 2024
1147578
add tests for adjoint
anurudhp Oct 30, 2024
e1dabca
imports and mypy
anurudhp Oct 30, 2024
b1165b3
`Y, Z`: explicitly implement ctrl sys (avoids AutoPartition in decomp)
anurudhp Nov 1, 2024
2d0c853
docstring `AdjointWithSpecializedCtrl`
anurudhp Nov 1, 2024
3793bb8
add notebook
anurudhp Nov 1, 2024
d025843
format
anurudhp Nov 1, 2024
db66528
Merge branch 'main' into 2024/10/29-refactor-walk-op
anurudhp Nov 1, 2024
a4d160c
simplify ctrl sys for CZ, CY
anurudhp Nov 2, 2024
32c0310
hubbard: not impl error on cv=0
anurudhp Nov 4, 2024
599f927
Merge branch 'main' into 2024/10/29-refactor-walk-op
anurudhp Nov 4, 2024
926c4a9
Merge branch 'main' into 2024/10/29-refactor-walk-op
anurudhp Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
hubbard: not impl error on cv=0
  • Loading branch information
@anurudhp
anurudhp committed Nov 4, 2024
commit 32c03101d48b237b76b2e5539e1c69d595eea6e2
4 changes: 3 additions & 1 deletion qualtran/bloqs/chemistry/hubbard_model/qubitization/select_hubbard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@ def __attrs_post_init__(self):
if self.x_dim != self.y_dim:
raise NotImplementedError("Currently only supports the case where x_dim=y_dim.")
if self.control_val == 0:
raise ValueError("control_val=0 not supported")
raise NotImplementedError(
"control_val=0 not supported, use `SelectHubbard(x, y).controlled(CtrlSpec(cvs=0))` instead"
)

@cached_property
def control_registers(self) -> Tuple[Register, ...]:
Expand Down
Loading