Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger on auto_merge_enabled #1037

Merged
merged 1 commit into from
Apr 12, 2025
Merged

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Apr 12, 2025

The trimming needs to be performed before the PR is merged so that the commit message is based on the trimmed version. This prevents us from using events such as the PR getting closed or merged. Triggering on merge queue events is also problematic, because a merge_queue event doesn't have the equivalent of "pull_request.user" and we need that to test if the PR came from Dependabot. So instead, this workflow triggers when auto-merge is enabled for the PR.

The trimming needs to be performed before the PR is merged so that the commit
message is based on the trimmed version. This prevents us from using events
such as the PR getting closed or merged. Triggering on merge queue events is
also problematic, because a merge_queue event doesn't have the equivalent of
"pull_request.user" and we need that to test if the PR came from Dependabot.
So instead, this workflow triggers when auto-merge is enabled for the PR.
@mhucka mhucka marked this pull request as ready for review April 12, 2025 03:19
@mhucka mhucka merged commit 22310f3 into quantumlib:master Apr 12, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant