Make it clearer dev-requirements does not contain dependencies by moving it to dev_tools/conf/pip-list-dev-tools.txt #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Strilanc
commented
Aug 3, 2018
Strilanc
commented
- Rename runtime-requirements.txt to just requirements.txt
- Inline contrib-requirements.txt into requirements.txt
- Refactor create_virtual_env to take multiple requirements files
- Move configuration files (e.g. .pylintrc) into dev_tools/conf
- Rename apt-runtime-requirements to apt-system-requirements
- Expand development documentation to discuss tools in check/ and expand on how to create a package
…ing it to dev_tools/conf/pip-list-dev-tools.txt - Rename runtime-requirements.txt to just requirements.txt - Inline contrib-requirements.txt into requirements.txt - Refactor create_virtual_env to take multiple requirements files - Move configuration files (e.g. .pylintrc) into dev_tools/conf - Rename apt-runtime-requirements to apt-system-requirements - Expand development documentation to discuss tools in check/ and expand on how to create a package
cduck
approved these changes
Aug 6, 2018
requirements.txt
Outdated
| networkx~=2.1 | ||
| numpy~=1.14 | ||
| protobuf~=3.5 | ||
| pylatex==1.3.* |
There was a problem hiding this comment.
Why move this from contrib-requirements? It's only used in contrib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.