Skip to content

Fix the type error in the Shor tutorial notebook #7655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the type error in the Shor tutorial notebook #7655

wants to merge 1 commit into from

Conversation

ToastCheng
Copy link
Contributor

The constructor of ModularExp expects integer or sequence of integer, instead of qubit. If the reader uncomment this line and execute, it will raise a type error.

@ToastCheng ToastCheng requested review from vtomole and a team as code owners September 18, 2025 16:12
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the Size: XS <10 lines changed label Sep 18, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.37%. Comparing base (82d2cdc) to head (4f5cb9e).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7655   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files        1085     1085           
  Lines       96937    96937           
=======================================
  Hits        96331    96331           
  Misses        606      606

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ToastCheng ToastCheng changed the title Fix the typo error in the Shor tutorial notebook Fix the type error in the Shor tutorial notebook Sep 18, 2025
@ToastCheng ToastCheng mentioned this pull request Sep 19, 2025
Closed
@ToastCheng
Copy link
Contributor Author

ToastCheng commented Sep 19, 2025 •
edited
Loading

Since there are some CI failures, I tried to rerun the tests and observed two issues:

  1. test_parallel_two_qubit_xeb_with_device seems flaky
    • Failed in Pytest Windows 3.11 in the first attempt
    • Failed in Pytest Ubuntu 3.12 in the second attempt (Pytest Windows pass)
    • Locally, I can't reproduce this failure
  2. mypy type check
    • This failure shows up in the third attempt (test_parallel_two_qubit_xeb_with_device passed this time on both Win and Ubuntu). Creating a separate issue CI type check mypy is failing #7656.

@ToastCheng
Fix the type error in the Shor tutorial notebook
4f5cb9e 
The constructor of ModularExp expects integer or sequence of integer
instead of qubits. If the reader uncomment this line and execute, it
will raise a type error.
@ToastCheng
Copy link
Contributor Author

All CI tests are passing, #7656 has been fixed by #7661, and the test_parallel_two_qubit_xeb_with_device error is not reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar tanujkhattar is a code owner automatically assigned from quantumlib/cirq-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ToastCheng