-
Notifications
You must be signed in to change notification settings - Fork 1.1k
update the RB fitting method to compensate for the standard deviation induced from the random number generator #7562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… induced from the random number generator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7562 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 1101 1101
Lines 99411 99432 +21
=======================================
+ Hits 96928 96949 +21
Misses 2483 2483 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@NoureldinYosri Could you please add a description to this PR? As a matter of best practices, we shouldn't leave PR descriptions empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the addition of a description to this PR and double-checking whether the test function name was really intended to be as it is written.
@@ -140,6 +140,22 @@ def test_parallel_single_qubit_parallel_single_qubit_randomized_benchmarking(): | |||
_ = results.plot_integrated_histogram() | |||
|
|||
|
|||
@mock.patch.dict(os.environ, clear='CIRQ_TESTING') | |||
def test_parallel_single_qubit_parallel_single_qubit_randomized_benchmarking_with_noise(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this function name have double "parallel_single_qubit"?
No description provided.